-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: .markdown-section max-width 800px to 80% #1017
Conversation
@jhoneybee can you please describe the reason or any point for this change |
The reason to modify 800px to percentage is as follows 1. The document is not beautiful under the huge screen.800px 80% Testable by browser zoom
|
I would suggest restoring docsify/src/themes/basic/_layout.styl Line 406 in bea19ed
This PR breaks the layout on mobile devices 😥. |
can you create an issue |
I created a PR (#1273) as it is so slight a problem. |
@anikethsaha Could you spare a few minutes to take a look. Thanks. |
@anikethsaha -- I know this has already been merged, but setting text width to 80% of the screen resolution is a bad idea. Standard practice for readability is 45-75 characters per line. Here's more detail: https://www.smashingmagazine.com/2014/09/balancing-line-length-font-size-responsive-web-design/
Filling more of the empty space may be visually preferable to some, but there's little argument to be made that this is better for everyone. My recommendation would be to revert this change and let those who prefer content to stretch for wide monitors to add their own custom CSS to a |
@jhildenbiddle how about #1273 ? |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
lib
directory.